Review of "Grab Song" version 2

Details Page Preview

A GNOME Shell extension that displays your currently playing Spotify song in the top panel and allows you to download it with a single click using spotdl.

Extension Homepage
https://github.com/sxoxgxi/grabsong

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You should close the pid on disable as mentioned before. 2. Timeout should be removed on destroy (line 52 and 96 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. As mentioned before, don't use sync spawn since that can freeze the shell process (line 5 and 35 `utils.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 4. Also you shouldn't use spawn for D-Bus. Use GJS for that: [D-Bus](https://gjs.guide/guides/gio/dbus.html)