Review of "Kanji Clock" version 2

Details Page Preview

Displays the time and date in the top bar in Kanji

Extension Homepage
https://gitlab.com/maxolasersquad/kanji-clock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove line 203-205 `extension.js`. not needed. 2. Remove `session-modes`: [EGO Review Guidelines: Metadata](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 3. You should also null out and disconnect `this._gnomeSettings` and `this._settings` signals on disable: - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) - [EGO Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals)