Review of "Kanji Clock" version 3

Details Page Preview

Displays the time and date in the top bar in Kanji

Extension Homepage
https://gitlab.com/maxolasersquad/kanji-clock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
You forgot to disconnect the signals on disable. Btw, it's better to don't use `this.getSettings()` for the GNOME's gsettings (line 15 `extension.js`). Please use this instead: ```js this._gnomeSettings = new Gio.Settings({schema_id: 'org.gnome.desktop.interface'}); ```