Review of "Net Totals Simplified" version 1

Details Page Preview

A Net totals extension that only displays totals.

Extension Homepage
https://github.com/avrain27/nettotalssimplified

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Rejected
4 Active
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove unnecessary files: - `quick-install.sh` - `Makefile` - `images/icon-full.png` - `images/icon-hires.png` - `images/icon.png` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Please remove `prefs`, `icon` and `icon-hires` from `metadata.json`. Not needed. 3. Timeout should be removed on disable and also before creating a new one since those functions can be called multiple times (line 59, 216, 226 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 4. Please don't create different timeouts and holding the ids in the same property (line 216 and 246 `extension.js`). I understand the current code removing the old one before creating a new one but looking at the diff in the future may be confusing for the reviewers. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions