Review of "Net Totals Simplified" version 10

Details Page Preview

A Net totals extension that only displays totals.

Extension Homepage
https://github.com/avrain27/nettotalssimplified

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:351
    input_file.load_contents(null)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:187
            this.tsLabel = new St.Label({
                text: 'Σ --',
                y_align: Clutter.ActorAlign.CENTER,
                x_expand: true,
                y_expand: false
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:452
                this._allocationTimeout = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 100, () => {
                    this._allocationTimeout = null;
                    this.updateStyles();
                    return GLib.SOURCE_REMOVE;
                })
  • extension.js:200
                this._styleTimeout = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 100, () => {
                    this._styleTimeout = null;
                    this.updateStyles();
                    return GLib.SOURCE_REMOVE;
                })
  • extension.js:55
            this.timeout = GLib.timeout_add_seconds(
                GLib.PRIORITY_DEFAULT,
                Math.ceil(refreshTime),
                () => this.parseStat()
            )

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['48', '49', '50', '51']

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:8
        getPreferencesWidget() {
            const settings = this.getSettings(SCHEMA_ID);
            let currentSettings = this._fetchSettings(settings);
    
            const vbox = new Gtk.Box({
                orientation: Gtk.Orientation.VERTICAL,
                margin_start: 25,
                margin_end: 25,
               

All Versions

Version Status
10 Active
9 Rejected
8 Rejected
7 Inactive
6 Inactive
5 Rejected
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active