This shows a pop-up of useful keyboard shortcuts when Ctrl + Alt + Shift + O is pressed
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
1. You cannot import `Gdk` to the GNOME Shell process (line 1 `extension.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) Also remove `GdkPixbuf` from the import in that line. 2. You have `getSettings` in `ExtensionUtils`. - line 10 `extension.js` - line 8-16 `prefs.js` Also you cannot create instances in global scope or constructor: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Remove `init()` (line 121 `extension.js`) and move them to enable and null them out in disable: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. I highly recommend to keep everything in classes since the files are large and keep tracking what you clean up on disable is really hard to review. Also keep the entry point class small. 5. Move line 7, 420-425 `prefs.js` to `buildPrefsWidget()`. 6. Don't call or hold instances in global scope: - line 20, 26 `prefs.js` - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 7. What's the reason for using hidden folder for `.files`? If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions