Review of "Shortcuts Popup" version 2

Details Page Preview

This shows a pop-up of useful keyboard shortcuts when Ctrl + Alt + Shift + O is pressed

Extension Homepage
https://github.com/slim8916/shortcuts-popup

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Please remove 42-44. Not compatible with those versions. 3. You don't need to use any parameters for `this.getSettings()` since you already specified that in `metadata.json`. 4. Already have `window` in the entry point, I recommend to not use `get_root()` (line 37 `prefs.js`). 5. What's the reason for that if condition (line 18-19 `common.js`)? Why not simply 6. Please use aysnc for reading file content since you are in shell process (line 107 `common.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 7. Don't add anything to the `extension` instance outside of the default class. That makes the cleanup review process super hard (line 55-89 `extension.js`). 8. Also create `uninit` that you call on disable and window close request in prefs (line 11 `common.js`): ```js window.connect('close-request', () => { // clean up here }); ```