Review of "Audio Switch Shortcuts" version 1.0.0 (1)

Details Page Preview

This extension allows you to switch speakers and microphones with global keyboard shortcuts, instead of using the mouse to open the Gnome Panel or navigate menus. It allows you to set specific audio devices to cycle through, and set your own hotkeys.

Extension Homepage
https://github.com/dbatis/gnome-shell-extension-audio-switch-shortcuts

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.0.6 (7) Active
1.0.5 (6) Active
1.0.4 (5) Active
1.0.3 (4) Active
1.0.2 (3) Active
1.0.1 (2) Active
1.0.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. No xml file for schemas and bad schemas id and path: [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) 2. Why are you creating another instance over the other one (line 144 `extenson.js`)? 3. You should call `removeFinishedTimeoutId()` in disable. 4. The settings you save in `gnomeSettings` should be called `settings` or something in your choice but don't call the extension settings GNOME Settings since that can be confusing for the reviewers. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
dbatis posted a review
Hi JustPerfection, thank you for your prompt review. This was very valid feedback and the mentioned issues have now been fixed and will be re-submitting now. Specifically to your points: 1. Sorry for missing this section in the guidelines, the schema ID and path have been changed accordingly. 2. This line has now been removed, it was an artifact from a very early test version. 3. The missing appropriate call to utils.js/disposeDelayTimeouts() has been added in disable(). 4. All references changed to extensionSettings so as to avoid confusion.
JustPerfection posted a review
Hi! And thanks for the fix. Newer version approved.