Review of "Audio Switch Shortcuts" version 1.0.7 (8)

Details Page Preview

This extension allows you to switch speakers and microphones with global keyboard shortcuts, instead of using the mouse to open the Gnome Panel or navigate menus. It allows you to set specific audio devices to cycle through, and set your own hotkeys.

Extension Homepage
https://github.com/dbatis/gnome-shell-extension-audio-switch-shortcuts

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:22
    this.extensionSettings = this.getSettings()
  • extension.js:160
    this.indicator = new PanelMenu.Button(0, this.metadata.name, false)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:153
                this.notificationSource.connect('destroy', _ => {
                    this.notificationSource = undefined;
                })

All Versions

Version Status
1.0.9 (10) Active
1.0.8 (9) Active
1.0.7 (8) Rejected
1.0.6 (7) Active
1.0.5 (6) Active
1.0.4 (5) Active
1.0.3 (4) Active
1.0.2 (3) Active
1.0.1 (2) Active
1.0.0 (1) Rejected

Previous Reviews on this Version

dbatis auto- rejected
Auto-rejected because of new version 1.0.8 (9) was uploaded