Review of "UXPlay Control" version 1

Details Page Preview

Control UXPlay AirPlay server from the top bar

Extension Homepage
https://xxanqw.pp.ua/

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't store any instance of objects in a property of the default class you are exporting (line 12 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) You can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 2. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 3. Don't use sync spawn since that can freeze the shell process (line 271 and 281 `extension.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 4. Use `Cancellable` instead of `kill` spawn command (line 271 and 281 `extension.js`): [GJS Guide: Cancellable Processes](https://gjs.guide/guides/gio/subprocesses.html#cancellable-processes) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions