Review of "Hue Control" version 2

Details Page Preview

Control Philips Hue rooms on local network

Extension Homepage
https://github.com/liamreoch/gnome-shell-extensions-hue-control

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Also null out in disable: ```js this._indicator = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. You should call `session.abort()` on disable or destroy. You are doing that in some files and they need to be fixed: [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 3. Use `console.*` instead of `log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging)