Review of "Hue Control" version 5

Details Page Preview

Control Philips Hue rooms on local network

Extension Homepage
https://github.com/liamreoch/gnome-shell-extensions-hue-control

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
line 119 `extension.js` should be disconnected on disable: [EGO Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals)
JustPerfection posted a review
btw, connecting signals for every time you open the quicksettings is a bad idea. Line 119-155 code block should be inside the `HueLightsToggle` class. For example: ```js #sync() { const bridgeIP = this._settings.get_string(SettingsKey.HUB_NETWORK_ADDRESS); // .. } ``` Then you can use it there.