Review of "OpenRGB Accent Color Sync" version 1

Details Page Preview

Synchronize GNOME accent colors with OpenRGB devices

Extension Homepage
https://github.com/evertonstz/openrgb-sync-accent-color

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on disable or destroy and also before creating a new once since those functions can be called multiple times: - line 137, 159, 171, 186, 197, 269, 290 `extension.js` - line 185, 216 `src/openrgb/network.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. When you use `settings-schema` in `metadata.json`, you don't need to pass anything to the `this.getSettings()` (line 8 `prefs.js`). I recommend to fix that. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions