Review of "Gnoming Profiles" version 3

Details Page Preview

Sync gsettings and user config files to GitHub with binary-safe wallpaper syncing and ETag-based polling for ultra-efficient bandwidth usage

Extension Homepage
https://github.com/gavindi/gnoming-profiles

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

gavindi posted a review
Hi again, Here's the current round of fixes 1) You should remove the timeout before creating a new one since the function can be called multiple times (line 268 `lib/SyncManager.js`) Fixed: timeout management issue in SyncManager.js https://github.com/gavindi/gnoming-profiles/commit/c4674afe88cfb04f9aece4b129b07eb20669a614 2) You forgot to remove the timeout on destroy (line 300 `lib/Utils.js`) 3) What's the use case of `debounce` and `throttle` anyway? Those functions are never used in your code. So why not just removing them? Fixed: Expunge of unused functions & methods This is a big one. I've delinted the code and found 27 methods/function that were unused and expunged them all. These built up over time as I was trying to do clever things with the code to make it more resilient however over time many of these were a one time use case and were better off built into other methods. https://github.com/gavindi/gnoming-profiles/commit/710d605e63947e04e517475500f0a407ebfba128 Cheers, Gavin
JustPerfection active
Thanks!