Review of "Picture desktop widget" version 1

Details Page Preview

A widget that allows you to display pictures on your desktop

Extension Homepage
https://github.com/GaszokS/Picture-desktop-widget

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't store any instance of objects in a property in the default class you are exporting (line 10 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) Please make it local to `fillPreferencesWindow()` function or you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 2. Also null out in disable: ```js settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions