Review of "Picture desktop widget" version 2

Details Page Preview

A widget that allows you to display pictures on your desktop

Extension Homepage
https://github.com/GaszokS/Picture-desktop-widget

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Creating settings instance many times is a bad practice. Please get it only once and use that instance (for both `prefs.js` and `extension.js`).
JustPerfection posted a review
For `extension.js`, doing this would be enough: ```js enable() { this.settings = this.getSettings(); } disable() { this.settings = null; } ``` and for `prefs.js` as I explained before, you can cleanup on window close request.