Review of "Idle Hamster" version 1

Details Page Preview

Stop tracking hamster activity's when idle

Extension Homepage
https://github.com/johnnyg/idle-hamster

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use white spaces between classes and function 2. Please remove `session-modes`: [EGO Review Guidelines: Metadata Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 3. Remove `gettext.js`. For gettext please read [GNOME Shell Port Guide 45](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 4. Please don't store any instance of objects in a property in the default class you are exporting (line 58-59, 67, 71 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to make them local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
johnnyg posted a review
1. Fixed 2. unlock-dialog session-mode is required for the extension to work so can't remove `session-modes` but have added a comment as per the guidelines 3. Removed `gettext.js` and used the gettext from `extension.js` 4. Fixed (by making them local)