Review of "Idle Hamster" version 5

Details Page Preview

Stop tracking hamster activity's when idle

Extension Homepage
https://github.com/johnnyg/idle-hamster

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:82
    this._settings = this.getSettings()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:118
                this._notificationSource.connect("destroy", (_source) => {
                    this._notificationSource = undefined;
                })

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:90
        async disable() {
            const logger = this.getLogger();
            this._todaysLastFact = undefined;
            for (let [_signalId, signal] of this._signals ?? []) {
                await signal?.disconnect();
            }
            this._signals?.clear();
            this._trackingActivityOnlySignals?.clear()

All Versions

Version Status
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

fmuellner active