1. Please add GitHub or GitLab url to the `metadata.json`: [EGO Review Guidelines: url](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Use new line between function names so it's more readable for the reviewers. Please don't it for the next version since the diff can be really large. You can do it after the extension gets approved. 3. D-Bus should `unexport` on destroy (line ) (line 35 `dbus_service.js`). 4. D-Bus interface name should start with `org.gnome.Shell.Extensions.` (line 35 `dbus_service.js`). 5. Don't use sync spawn since that can freeze the shell process (line 109 `xprop.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) 6. Timeout should be removed on disable: - line 302, 376, 1075, 1734, 1800, 1903 `extension.js` - line 322 `window.js` - line 92 `panel_settings.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 7. Please don't call functions in global scope (line 18 `window.js`): [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 8. Please don't use deprecated modules: - line 363 `extension.js` - line 24, 158 `utils.js` - line 9 `floating_exceptions/main.js` - line 217 `floating_exceptions/config.js` - line 112 `xprop.js` - line 215 `config.js` [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules) 9. The process should be canceled or exit on disable (line 357 `extension.js`). 10. Also null out in disable: ```js ext = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 11. Call `disable_window_attention_handler()` in disable and remove line 2110 `extension.js`. 12. You really don't need `show_all()` in GNOME Shell 45+ (line 13 `prefs.js`). 13. Is this official GNOME? Asking that because I'm seeing `gnome` in schema id and path. 14. You don't need to use `load_theme()` (line 2169 `extension.js`). Simply use `stylesheet-light.css` and `stylesheet-dark.css` and GNOME Shell will manage those styles. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions