EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• config.js:224

  file.value.load_contents(null)

• utils.js:179

  GLib.file_get_contents('/etc/os-release')

• utils.js:23

  file.load_contents(null)

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

• prefs.js:230

  keyController.run_dispose()

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

• context.js
• floating_exceptions/config.js
• floating_exceptions/main.js
• floating_exceptions/utils.js

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

• extension.js:114

              this.settings.int.connect('changed::gtk-theme', () => {
                  this.register(Events.global(GlobalEvent.GtkThemeChanged));
              })

• extension.js:119

              this.settings.shell.connect('changed::name', () => {
                  this.register(Events.global(GlobalEvent.GtkShellChanged));
              })

• extension.js:2279

  id = actor.connect('first-frame', () => {
                      if (this.grab_op !== null) {
                          this.schedule_deferred_tile(win);
                      }
                      else {
                          this.tile_instant(win);
                      }
                      actor.discon

• extension.js:2279

  actor.connect('first-frame', () => {
                      if (this.grab_op !== null) {
                          this.schedule_deferred_tile(win);
                      }
                      else {
                          this.tile_instant(win);
                      }
                      actor.disconnect(

• extension.js:1884

              this.schedule_idle_timeout = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 100, () => {
                  if (!this.movements.is_empty())
                      return true;
                  return func();
              })

• extension.js:1884

  GLib.timeout_add(GLib.PRIORITY_DEFAULT, 100, () => {
                  if (!this.movements.is_empty())
                      return true;
                  return func();
              })

• extension.js:2206

  GLib.timeout_add(GLib.PRIORITY_LOW, 100, check)

• extension.js:677

              this.border_timeout = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 250, () => {
                  this.is_switching_workspace = false;
                  this.show_border_on_focused();
                  this.border_timeout = null;
                  return GLib.SOURCE_REMOVE;
              })

• extension.js:677

  GLib.timeout_add(GLib.PRIORITY_DEFAULT, 250, () => {
                  this.is_switching_workspace = false;
                  this.show_border_on_focused();
                  this.border_timeout = null;
                  return GLib.SOURCE_REMOVE;
              })

• extension.js:453

          this.exception_select_timeout = GLib.timeout_add(GLib.PRIORITY_LOW, 500, () => {
              this.exception_selecting = true;
              overview.show();
              return false;
          })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• panel_settings.js:28

          this._toggle.connect('clicked', () => {
              ext.toggle_tiling();
          })

• panel_settings.js:73

          item.connect('activate', () => {
              ext.exception_dialog();
          })

• panel_settings.js:80

          item.connect('activate', () => {
              ext.open_settings();
          })

• panel_settings.js:52

          item.connect('toggled', (_, state) => {
              ext.settings.set_smart_gaps(state);
          })

• panel_settings.js:59

          item.connect('toggled', (_, state) => {
              ext.settings.set_active_hint(state);
          })

• panel_settings.js:66

          item.connect('toggled', (_, state) => {
              ext.settings.set_mouse_cursor_follows_active_window(state);
          })