Review of "Hide System Icons" version 2

Details Page Preview

Hide system icons in the Quick Settings panel for GNOME.

Extension Homepage
https://github.com/shichen35/hide-system-icons

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
22 Active
21 Active
20 Active
19 Rejected
18 Active
17 Rejected
16 Rejected
15 Active
14 Rejected
13 Rejected
12 Active
11 Rejected
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Chen Shi posted a review
JustPerfection rejected
1. Please don't store any instance of objects in a property in the default class you are exporting (line 7 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to make it local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 2. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions