Review of "Text Clock" version 1.1.0 (6)

Details Page Preview

A simple text clock for the GNOME Shell

Extension Homepage
https://github.com/wtbenica/text-clock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.1.1 (7) Active
1.1.0 (6) Rejected
1.0.5 (5) Inactive
1.0.4 (4) Inactive
1.0.3 (3) Inactive
1.0.2 (2) Inactive
1.0.1 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please don't use sync spawn since that can freeze the shell process (line 51 `presentation/preferences/helpers.js`): [GJS Guide: Subprocesses](https://gjs.guide/guides/gio/subprocesses.html#complete-examples) Anyway, you should remove line 41-85 `presentation/preferences/helpers.js` and use the `misc/config` module instead: in `extension.js` process: ```js import * as Config from 'resource:///org/gnome/shell/misc/config.js'; const shellVersion = parseFloat(Config.PACKAGE_VERSION); ``` in `prefs.js`: ```js import * as Config from 'resource:///org/gnome/Shell/Extensions/js/misc/config.js'; const shellVersion = parseFloat(Config.PACKAGE_VERSION); ``` 2. It will also available in shell process (line 36 `utils/error_utils.js`). Please don't use old `imports`. 3. You cannot create instances of objects in global scope (line 31 `extension.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Timeout should be removed on destroy and also before creating a new one (line 194 `services/notification_service.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)