Review of "Text Clock" version 1.0.1 (1)

Details Page Preview

A simple text clock for the GNOME Shell

Extension Homepage
https://github.com/wtbenica/text-clock

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
1.0.4 (4) Active
1.0.3 (3) Inactive
1.0.2 (2) Inactive
1.0.1 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
Please don't store any instance of objects in a property in the default class you are exporting (line 29 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) You can make it local to `fillPreferencesWindow()` or you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions