Review of "Text Clock" version 1.1.3 (12)

Details Page Preview

A simple text clock for the GNOME Shell

Extension Homepage
https://github.com/wtbenica/text-clock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:70
    this.#topBox = new St.BoxLayout({ style_class: CLOCK_STYLE_CLASS_NAME })

All Versions

Version Status
1.1.3 (13) Active
1.1.3 (12) Rejected
1.1.3 (11) Rejected
1.1.2 (10) Inactive
1.1.2 (9) Rejected
1.1.2 (8) Rejected
1.1.1 (7) Inactive
1.1.0 (6) Rejected
1.0.5 (5) Inactive
1.0.4 (4) Inactive
1.0.3 (3) Inactive
1.0.2 (2) Inactive
1.0.1 (1) Rejected

Previous Reviews on this Version

benica.dev posted a review
Re shexli warning: - #topBox is destroyed and set to undefined in extension.js:118-19
JustPerfection rejected
Please remove unnecessary try-catch wrappers from `extension.js` and send it again.