Review of "Text Clock" version 1.1.2 (8)

Details Page Preview

A simple text clock for the GNOME Shell

Extension Homepage
https://github.com/wtbenica/text-clock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • constants/dates/extension.js
  • constants/dates/prefs.js
  • constants/times/extension.js
  • constants/times/prefs.js
  • utils/gettext/gettext_utils.js
  • utils/logging/logger_interface.js

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:76
    this.#settings = this.getSettings()
  • extension.js:122
            this.#topBox = new St.BoxLayout({
                style_class: CLOCK_STYLE_CLASS_NAME,
            })

All Versions

Version Status
1.1.2 (10) Active
1.1.2 (9) Rejected
1.1.2 (8) Rejected
1.1.1 (7) Active
1.1.0 (6) Rejected
1.0.5 (5) Inactive
1.0.4 (4) Inactive
1.0.3 (3) Inactive
1.0.2 (2) Inactive
1.0.1 (1) Rejected

Previous Reviews on this Version

SriramRamkrishna rejected
Please make sure that the shellxi static analyzer runs clean. You can install that with pip3 install shexli and run it against your extension.
benica.dev posted a review
Both are false positives. The "unreachable" files are both used for translations. In `disable`, `#cleanup` is called, in which #settings is destroyed. I figured things were okay since that had already been manually reviewed by JustPerfection.
benica.dev posted a review
Sorry, I see that `logger_interface.js` is basically empty, so I'll get rid of that, and I'll resubmit, along with specific explanations for the shexli errors.
benica.dev posted a review
Sorry, I see that `logger_interface.js` is basically empty, so I'll get rid of that, and I'll resubmit, along with specific explanations for the shexli errors.