Review of "1440" version 1

Details Page Preview

Make every minute count. Inspired by https://1440app.com/

Extension Homepage
https://github.com/ravener/gnome-1440

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Wrong path in the xml file (line 3 `schemas/org.gnome.shell.extensions.OneFourFourZero.gschema.xml`). 3. Please don't store any instance of objects in a property in the default class you are exporting (line 21-22 `prefs.js`) that won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you don't want to move them local to `fillPreferencesWindow()` function, you can clean up on: ```js window.connect('close-request', () => { // clean up here }); ``` 4. Don't use `this.getSettings()` for GNOME settings. Use this instead: ```js new Gio.Settings({schema_id: CLOCK_SCHEMA}); ``` - line 38 `extension.js` - line 22 `prefs.js` 5. Should be disconnected on disable (line 51 `extension.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions