GNOME Shell Extensions

Review of "1440" version 3

Details Page Preview

1440

by ravener

Make every minute count. Inspired by https://1440app.com/

Extension Homepage
https://github.com/ravener/gnome-1440
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:117 
    this._menuLabel = new PopupMenu.PopupMenuItem('')

All Versions

Version Status
3 Unreviewed
2 Active
1 Rejected

Previous Reviews on this Version

Ravener posted a review
Is the Shexli warning important? I think that gets destroyed as part of the children of the menu