Review of "Adaptive Brightness" version 3

Details Page Preview

This extension is a customizable alternative of 'Automatic Screen Brightness' found in GNOME settings. Features: • Smooth transitions that prevent flickering in changing light • Customizable brightness response to ambient light • Automatic keyboard backlight control in low-light conditions Requires Ambient Light Sensor (ALS) hardware support. Check the extension's home page for device compatibility.

Extension Homepage
https://github.com/dmy3k/gnome-adaptive-brightness

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `session-modes`: [EGO Review Guidelines: Metadata Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Remove all of those try and catch wrappers from enable. You shouldn't call disable from enable. 3. Also null them out (279-294 `extension.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Move line 12-13 `lib/BrightnessDbus.js` to `BrightnessDbus`: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
dmy3k posted a review
Thanks for thorough review