Review of "Soft Brightness Plus" version 24

Details Page Preview

Add or override the brightness slider to change the brightness via an alpha layer (and optionally stop using or cooperate with the exising backlight, if present). Either internal, external or all monitors can be dimmed. See the GitHub page for details. Note that this extension will keep running on the lock screen, as you'd also want the brightness setting to apply to the lock screen as well. Please report on GitHub if this gives you any trouble. This extension is a fork of the original 'Soft brightness' extension, and maintains support for new GNOME releases.

Extension Homepage
https://github.com/jkitching/soft-brightness-plus

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
25 Active
24 Rejected
23 Active
22 Active
21 Active
20 Rejected
19 Active
18 Active
17 Rejected
16 Active
15 Inactive
14 Active
13 Inactive
12 Rejected
11 Active
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
You should remove line 556-558 `extension.js`, falls under selective disable. Also, in line 560, you are nulling out `this._indicator` and then want to use it on line 572. So, moving line 560-561 to the end of disable should be enough. Also, remove line 551-553 `extension.js`, not needed and that is going to prevent the extension to go to the full disable.
jkitching posted a review
Done! Please check the updated version.