GNOME Shell Extensions

Review of "Soft Brightness Plus" version 32

Details Page Preview

Soft Brightness Plus

by jkitching

Add or override the brightness slider to change the brightness via an alpha layer (and optionally stop using or cooperate with the exising backlight, if present). Either internal, external or all monitors can be dimmed. See the GitHub page for details. Note that this extension will keep running on the lock screen, as you'd also want the brightness setting to apply to the lock screen as well. Please report on GitHub if this gives you any trouble. This extension is a fork of the original 'Soft brightness' extension, and maintains support for new GNOME releases.

Extension Homepage
https://github.com/jkitching/soft-brightness-plus
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-C49-005 error

extensions targeting GNOME 49 must not call Meta.CursorTracker.set_pointer_visible

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.CursorTracker.set_pointer_visible()`.

Meta.CursorTracker

  • extension.js:988 
    this._cursorTracker.set_pointer_visible(true)
  • extension.js:1007 
    this._cursorTracker.set_pointer_visible(false)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • utils.js:27 
    file.load_contents(null)

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:185 
        disable() {
        // In order to maintain the same brightness settings when the device is
        // locked and unlocked, "session-modes" includes "unlock-dialog" in
        // metadata.json.  The extension will remain active while the lock screen
        // is shown.
        this._logger.log_

All Versions