1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Remove unnecessary files: - `install` - `install.sh` - `INSTALL.md` - `multi-monitors-add-on.pot` - `README-GNOME46-UPDATE.md` - `CHANGELOG-GNOME46.md` - `.po` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 3. Is this a fork? If it is, you need to mention it in the description. 4. Remove `convenience.js`. You already have in the entry point: - `this` as current extension. - No need to use `initTranslation()`: > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) - `this.getSettings()` already exist. 5. The comments wrapped the `ExtensionEntryPoint` in `extension.js` are not necessary. Please remove them. 6. Remove line 361-397 `extension.js`. Not needed. 7. `init()` never gets called (line 477-480 `extension.js`). 8. Selective disable isn't allowed (line 456-457 `extension.js`). 9. Create settings instance in the entry point and pass them to the classes and functions needing it (for example, don't do that in line 100 `extension.js`). 10. Avoid wrapping code with unnecessary try and catch blocks. You are doing it in many lines. 11. Too many logs. logs should be only available in debug mode. 12. Cleanup in disable (line 352, 357-359 `extension.js`). 13. This is 45+ package. Remove line 34-47, 49 `indicator.js`. 14. Rename `_onDestroy` to `destory` and do `super.destroy()` at the end of that function (line 60 `indicator.js`). You already using `_onDestroy()` in other files. Please fix those too. 15. Remove line 107-119 `indicator.js`. Already have `this.openPreferences()` in the entry point. 16. Extensions cannot use `run_dispose()`: - line 514 `indicator.js` - line 121, 514 `mmcalendar.js` [EGO Review Guidelines: run_dispose](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject) 17. Use this instead (line 68 `mmlayout.js`): ```js this._desktopSettings = new Gio.Settings({schema_id: 'org.gnome.desktop.interface'}); ``` 18. Don't import gettext the old way: - line 38-40 `mmoverview.js` - line 39-41 `mmcalendar.js` - line 41-43 `mmpanel.js` [Port Guide 45: gettext](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 19. Should be disconnected on destroy (line 110-117 `mmoverview.js`). Don't forget to call destroy on instances. 20. Remove line 221, 223-234 `mmoverview.js`. 21. The doing nothing (line 324-338 `mmoverview.js`). 22. Please don't send unnecessary and large amount of code. That just makes the review process hard and longer. 23. If that's not compatible with 40+ it should be removed (line 355-431 `mmoverview.js`). 24. Don't import unnecessary modules (line 35, 37 `mmcalendar.js`). 25. Remove unnecessary lines (line 45-46 `mmpanel.js`). `Main` is already accessible in other modules. 26. What's the reason for monitoring the update session? Your extension gets re-enabled on each unlock: - line 410 `mmcalendar.js` - line 78 `mmpanel.js` 27. What's the reason for using `vfunc_destroy()` instead of `destroy()` (line 569 `mmpanel.js`)? If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions