Review of "Multi Monitor Bar" version 30

Details Page Preview

Fork of spin83's Multi Monitors. This extension is not going to be maintain anymore. Need to work on real project with benefits for now. Fork it if you want. The donate button is still functioning though lol...... Cheerss

Extension Homepage
https://github.com/FrederykAbryan/multi-monitors-bar_fapv2

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 2. You already have destroy function. Move eveything from line 46-107 `mirroredIndicatorButton.js` to the `destroy()`. 3. Timeout should be removed on destroy and alos before creating a new one: - line 412, 459 `mirroredIndicatorButton.js` - line 760, 768, 811, 940 `mmoverview.js` - line 192, 474, 527, 583 `screenshotPatch.js` 4. Unnecessary checks and try-catch wrappers still happening in this versions. Please note, we have a rul for AI: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) 5. Avoid sending large diff. It's hard to review.
AbryanPalinoan posted a review
The timeouts in mmoverview.js and screenshotPatch.js are one-shot timeouts that return GLib.SOURCE_REMOVE. These don't need pre-creation cleanup because they self-terminate and aren't stored as instance variables. Should i do it other way ?
AbryanPalinoan posted a review
sorry for the large diff since i do fix a lot of bugs and add two big feature in it
JustPerfection posted a review
Yes, those timeouts should be also removed. As we mentioned in the guidelines: > Note that all sources MUST be removed in disable(), > even if the callback function will eventually return false > or GLib.SOURCE_REMOVE. [EGO Review Guidelines: Remove main loop sources](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)