Review of "Night Light Toggle" version 1

Details Page Preview

A minimal status bar indicator to toggle Night Light mode.

Extension Homepage
https://github.com/egoistpizza/night-light-toggle

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please remove `assets/night-light-toggle-preview.gif`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
JustPerfection posted a review
Also rename `_onDestroy` to `destroy()` (line 60 `extension.js`) and do `super.destroy()` at the end of that function.
egoistpizza posted a review
Hi, thanks for the review and the helpful tips! I really appreciate it. I've addressed the points you raised: 1. Renamed `_onDestroy` to `destroy()` and fixed the super call. 2. Removed the GIF file from the packages. 3. Added donation info to `metadata.json`. 4. Bumped the versions. I uploaded Version 3 for Legacy (40-44) and Version 4 for Modern (45+) support.