GNOME Shell Extensions

Review of "Night Light Toggle" version 6

Details Page Preview

Night Light Toggle

by egoistpizza

A minimal status bar indicator to toggle Night Light mode.

Extension Homepage
https://github.com/egoistpizza/night-light-toggle
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Active
8 Active
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Disconnect then null out (line 110 `extension.js`). 3. Extensions cannot use `run_dispose()` (line 107 `extension.js`): [EGO Review Guidelines: run_dispose](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject)
egoistpizza posted a review
Thanks for the review. I removed the compiled schema file and replaced run_dispose with proper signal disconnection and object nulling, as advised.