Review of "Numeric Date And Clock" version 15

Details Page Preview

Numeric Clock replaces the GNOME top-bar clock with a clean, fully configurable numeric date/time. Use any strftime format (e.g. %A %d/%m/%Y %H:%M) and see changes instantly in the live preview. Features: Custom format string with instant-apply preview Optional “Only override top bar DateMenu” mode Smooth seconds when the interval is set to 1s Update interval range: 1–300 seconds Presets for quick setup (Default / Seconds) i18n-ready labels and a Donate button in Preferences Works on Wayland and Xorg, with builds for current and legacy GNOME versions No network access, no telemetry — settings stay on your machine Source code, issues, and releases: https://github.com/nickotmazgin/Linux-Numeric-Date-And-Clock

Extension Homepage
https://github.com/nickotmazgin/Linux-Numeric-Date-And-Clock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

Ghost posted a review
Submission UUID: numeric-clock@nickotmazgin Target: GNOME Shell 45–47 Extension version: 15 Builds: ESM modules for 45–47; classic modules for 42–44 kept as legacy Summary Adds two new preferences: Only override top bar DateMenu Smooth tick (align to second boundary) when interval = 1s Adds presets (Default, Seconds), expands update interval range to 1–300s Preferences UX improvements: live preview, reset to defaults i18n scaffolding (gettext domain: numeric-clock) No new permissions, no network access; UUID unchanged Schema GSettings schema: org.gnome.shell.extensions.numeric-clock New keys: only-topbar (boolean), smooth-second (boolean) Update interval now has <range min="1" max="300"/> Defaults preserve previous behavior (only-topbar=false, smooth-second=false) Code Notes GNOME 45–47 build uses ESM imports: imports from gi:// and resource:/// per Shell 45+ guidance Legacy 42–44 build continues to use imports.gi/imports.ui Extension sets plain text only (no Pango markup) and re-applies on label text changes When “Only top bar” is ON, changes are limited strictly to the DateMenu label Compatibility 45–47: tested with ESM entrypoints and Adwaita/GTK preferences 42–44: legacy branch kept in sync functionally (same prefs/options), classic prefs entrypoint No API deprecations used for targeted Shell versions Packaging/Compliance 45–47 ZIP does NOT include schemas/gschemas.compiled 42–44 ZIP DOES include schemas/gschemas.compiled Both zips contain metadata.json, extension.js, prefs.js, and the XML schema Icon included in metadata; gettext-domain set Testing Hints Enable extension and open Preferences: Change format string → label updates immediately Toggle “Only override top bar” → limits changes strictly to the top bar Toggle “Smooth tick” + set interval = 1 → first update aligns to the next second boundary Presets: “Default” (60s), “Seconds” (1s) apply instantly Legacy Build (42–44) A corresponding legacy update is available with the same user‑visible changes Extension version: 14 (classic modules; includes compiled schema in ZIP) Submit separately for Shell 42–44 if needed Provenance Source: https://github.com/nickotmazgin/Linux-Numeric-Date-And-Clock Release with both zips and notes: https://github.com/nickotmazgin/Linux-Numeric-Date-And-Clock/releases/tag/v15.0.0
JustPerfection waiting for author
1. I requested for `icon` removal from `metadata.json` in version 6. It was removed but it is back again. What's the reason for including it again? 2. This one also has the unnecessary catch in line 61 `extension.js`. Is this code generated by AI?
Ghost auto- rejected
Auto-rejected because of new version 17 was uploaded
JustPerfection waiting for author
Ghost posted a review
why straight ai it could of just has been scripts or auto compilers i use in github repos. do you ask the same thing other devs too or just me?! - automated scripts and compilers. i mainly use visual studio code, warp, cursor, codex, and some ai agents only if it gets too deep and heavy, it really depends but for advice and tip and corrections i do use ai agents sometimes occasionally though/thought.. i dunno you keep bringing up that ai again and again dunno.. anyhow i will need to correct the codes in both releases codes etc i also added the metadata.json donate and in-extension donate... etc so i will get the zips ready with your advice to correct etc and upload them.
Ghost auto- rejected
Auto-rejected because of new version 19 was uploaded
JustPerfection posted a review
Well, I review many lines daily, and reverting to what was fixed before or adding any unnecessary code can make the review process longer. It makes the other extensions wait in the review queue longer. I brought up AI usage because: - Your [other extension](https://extensions.gnome.org/review/66333) also had so many unnecessary try and catch blocks, which is an indication of AI usage. - The extension description here also seems heavily proofed by AI. - This extension uses unnecessary `=== 'function'` checks 11 times. As you can see, we have a strict rule for AI usage in our review guidelines, which was added about four days ago: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) Anyway, I approved your extension because you actually fixed what I requested. I recommend to: - Make the description more readable by focusing only on what the extension does. - Avoid sending unnecessary code. And please don't get frustrated during the review process. It's all about helping and improving the code and user experience. If you need any help or explanation, feel free to ask here or on [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org).
Ghost posted a review
Hi @JustPerfection, Thanks again for reviewing my extensions and for approving the latest Numeric Clock and ClipFlow Pro versions. I know you go through a lot of code every day, and I do appreciate the time and care you invest in the queue. About AI usage and authorship I want to clarify something directly because of the new “Extensions must not be AI-generated” guideline and because AI has been mentioned a few times in relation to my submissions. These extensions (Numeric Clock and ClipFlow Pro) are written and maintained by me. I use modern tools (VS Code, Cursor, linters, etc.), and occasionally I’ll consult an AI assistant for a suggestion, wording, or to sanity-check an approach, but I don’t paste in large blocks of code I don’t understand or ship code I can’t explain. I’m fully responsible for the final code. Some of the patterns you called out — lots of defensive try/catch blocks, or typeof panel.disconnect === 'function'-style checks — are on me. They came from me being overly defensive and refactoring quickly, not from dumping an AI transcript. I understand why, especially under the new guideline, those patterns look like “AI artifacts” and trigger extra scrutiny. Just to be explicit: My extensions are not AI-generated, and I can justify and walk through the logic in them. Where the style smells like generic AI, that’s my mistake in style, not in authorship. Respecting the AI guideline going forward I want to work with the review team, not against it, so I’ll adapt my process: Clean up unnecessary guards and empty catch {} blocks instead of leaving them around “just in case.” Avoid redundant typeof … === 'function' checks when the GNOME Shell APIs already guarantee the signals/methods. Keep the EGO descriptions shorter and focused on what the extension does, and move more detailed change logs to GitHub. That way I stay within both the letter and spirit of the AI guideline, and I also make your job easier when you scan the diffs. On the icon regression and other details You’re right that the icon in metadata.json came back after you’d previously asked for its removal. That wasn’t meant as ignoring your feedback; it re-appeared when I was adjusting metadata/donation details and I didn’t connect it to the earlier request. I’m happy to keep it aligned with the current expectations and not re-introduce it unless there’s a clear OK for doing so. Tone, frustration, and mutual respect I’ll be honest: having AI brought up repeatedly around my extensions did feel a bit personal and discouraging, especially when I put a lot of time and care into the code and UX. I completely understand you have to enforce the new AI policy and flag suspicious patterns; I’m not arguing against that. What I’m asking for is that this happens with the same basic assumption of good faith you’d give any other developer: I’m here as a real person, working hard on these projects, happy to fix issues and learn from feedback — not trying to sneak in an auto-generated extension. My intent is to keep improving both the code and the user experience, and to be a constructive long-term part of the GNOME extensions ecosystem. If there are other concrete patterns you’d like me to avoid (beyond the ones you already mentioned), I’d appreciate you pointing them out once more so I can add them to my pre-upload checklist. Thanks again for the review work you do and for the approval after the requested fixes.
JustPerfection posted a review
Hi Nick, Please don't take the review personally. The code review is all about the code, not the person behind it. As a matter or fact, you've already proven you are a good human being just by sharing the code with the world for free. Thank you for understanding.