Review of "Smart Auto Move" version 36

Details Page Preview

Smart Auto Move learns the position, size, and workspace of your application windows and restores them on subsequent launches. Supports Wayland. NOTE: Optimized for use with static workspaces. For more control, set the default behavior to IGNORE and then selectively RESTORE only desired apps.

Extension Homepage
https://github.com/khimaros/smart-auto-move

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Avoid sending large diff. Makes the review process harder and longer. 2. What's the reason for including `lib/README.md`? 3. You shouldn't run mainloop in extensions (line 364 `lib/state-session.js`). 4. Timeout should be removed on disable/destroy and before creating a new one: - line 352, 552 `lib/state-session.js` - line 219, 393 `lib/state-matcher.js` - line 84 `lib/utils.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) The thing withe all of these timeouts is that, tracking for removal in disable is not easy. One solution would be making a helper function for timeout. That function can hold all the timeout ids after creating them. Then, on disable, call another helper function that removes all the timeouts created before.