Review of "History Manager Prefix Search" version 24

Details Page Preview

Use PageUp and PageDown to move in HistoryManager (eg. Run Command, Looking Glass) according to prefix

Extension Homepage
https://github.com/sustmi/gnome-shell-extension-historymanager-prefix-search

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
25 Unreviewed
24 Rejected
23 Active
22 Active
21 Active
20 Active
19 Rejected
18 Active
17 Active
16 Rejected
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
Please remove `eslint.config.js`.
sustmi posted a review
Thanks for your review. How am I supposed to run ESLint then? Without the file, I get an error that the file is missing when trying to run ESLint: ```sh $ make check npm run check > check > eslint --format codeframe *.js Oops! Something went wrong! :( ESLint: 8.29.0 ESLint couldn't find a configuration file. To set up a configuration file for this project, please run: npm init @eslint/config ESLint looked for configuration files in /home/mirek/git_projects/gnome-shell-extension-historymanager-prefix-search and its ancestors. If it found none, it then looked in your home directory. If you think you already have a configuration file or if you need more help, please stop by the ESLint chat room: https://eslint.org/chat/help ```
JustPerfection posted a review
That file can be used for development environment but not for the package you are sending here. I recommend to use `gnome-extensions pack` for the zip package you are sending here. You can use my script if you want: https://gitlab.gnome.org/jrahmatzadeh/just-perfection/-/blob/main/scripts/build.sh?ref_type=heads
JustPerfection posted a review
Also, please remove `schemas/gschemas.compiled`. Not needed for 45+ packages.
sustmi posted a review
Oh, sorry. Only now I realized this is not a review of whole Git repository but just the ZIP archive. 😅 Thanks for mentioning the `gnome-extensions pack`. I did not know about that. I submitted a new version. Now, the ZIP does no longer contain `eslint.config.js` and `gschemas.compiled`.