Review of "Perf-Switcher-Asusctl" version 1

Details Page Preview

Simple Performance Profile switcher Gnome-Shell-Extension for ASUS laptops using asusctl. Forked from GPU-Switcher-Supergfxctl by chikobara. This extension is not affiliated, funded, or in any way associated with Asus.

Extension Homepage
https://github.com/Rea1-ms/Perf-Switcher-Asusctl

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
4 Unreviewed
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove `img/src.png`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Please add this to the description: > This extension is not affiliated, funded, or in any way associated with Asus. 3. Add this to the `Indicator` class: ```js destroy() { this._toggle?.destroy(); super.destroy(); } ``` 4. I think you should be able to use d-bus to change the profile without subprocess. What's the issue for not doing that? 5. You should mention in the description that this is a fork of the other extension. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions