Review of "Perf-Switcher-Asusctl" version 4

Details Page Preview

Simple Performance Profile switcher Gnome-Shell-Extension for ASUS laptops using asusctl. Forked from GPU-Switcher-Supergfxctl by chikobara. This extension is not affiliated, funded, or in any way associated with Asus.

Extension Homepage
https://github.com/Rea1-ms/Perf-Switcher-Asusctl

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:125
    console.error(`Failed to fetch supported profiles: ${e.message}`)
  • extension.js:153
    console.error(`Unknown profile value: ${profileValue}`)
  • extension.js:157
    console.error(`Failed to fetch current profile: ${e.message}`)
  • extension.js:188
    console.error(`Unknown profile: ${profile}`)
  • extension.js:211
    console.error(`Failed to set profile via DBus: ${e.message}`)
  • extension.js:227
    console.error(`Unknown profile: ${profile}`)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:71
    this._profileSection = new PopupMenu.PopupMenuSection()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:71
    this._profileSection = new PopupMenu.PopupMenuSection()

All Versions

Version Status
4 Unreviewed
3 Active
2 Rejected
1 Rejected