Review of "Webling" version 2

Details Page Preview

A small easy-access utility type web browser for a single monitor setup.

Extension Homepage
https://github.com/noobaldrin/gnome-shell-extension-webling

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove: - `org.gnome.shell.extensions.webling.gschema.xml` - `stylesheet.css` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Timeout should be removed on disable (line 29, 43 `windowmanager.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 4. Please disconnect signals on disable (line 19, 25, 39, 51, 79, 104 `windowmanager.js`): [EGO Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) 5. Move to enable and null it out in disable (line 27 `extension.js`): - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
th0gz19 posted a review
Hello, Apologies for the late response, but is there a deadline to submit another version of the extension? I'm going to upload a newer version.
JustPerfection posted a review
Hi, No deadline. Take your time.
th0gz19 posted a review
Thank you. I uploaded a newer one with the changes. Let me know if I missed something or if something needs polishing.