Review of "Webling" version 3

Details Page Preview

A small easy-access utility type web browser for a single monitor setup.

Extension Homepage
https://github.com/noobaldrin/gnome-shell-extension-webling

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please move out of the parent `if` condition (line 211-214, 226-229 `windowmanager.js`). 2. You are still not disconnecting all signals in `windowmanager.js`. You can use `connectObject()` and `disconnectObject()` instead, so it is easier to clean up. 3. Line 33-34 `extension.js` is a bad practice. You should only use `org.gnome.shell.extensions.webling`. Don't make sub settings without any good reason. Also, fix schema XML file after that. The id and path are wrong there.