Review of "Pomodoro Timer" version 1.1.1 (4)

Details Page Preview

Pomodoro timer with adjustable intervals, sound notifications, and auto-suspend prevention.

Extension Homepage
https://github.com/Oguzhankokulu/pomodoro-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version Status
2.2 (10) Active
2.1 (9) Active
2.0 (8) Active
2.0 (7) Rejected
1.3 (6) Active
1.2 (5) Active
1.1.1 (4) Rejected
1.1 (3) Rejected
1.0.1 (2) Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `assets/Screenshots`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 3. Move to `SuspendInhibitor` class (line 21 `src/suspendInhibitor.js`). 4. You shouldn't play sound with spawn commands (line 45-68 `src/sound.js`): ```js let player = global.display.get_sound_player(); let file = Gio.File.new_for_path('PATH TO THE FILE'); player.play_from_file(file, 'title', null); ``` 5. You cannot use spawn command to open prefs. Use `this.openPreferences()` from the entry point (line 400-404 `src/indicator.js`). 6. Nothing in `extension.js` and seems everything is in `src` folder. Please don't send extensions without testing. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions