Review of "Pomodoro Timer" version 2.1 (9)

Details Page Preview

Pomodoro timer with adjustable intervals, sound notifications, and auto-suspend prevention.

Extension Homepage
https://github.com/Oguzhankokulu/pomodoro-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO030 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • dataStore.js:18
    this._file.load_contents(null)

EGO015 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • indicator.js:73
    this._durationBtn.connect('clicked', () => this._startEditing())
  • indicator.js:80
    this._entry.clutter_text.connect('activate', () => this._finishEditing())
  • indicator.js:81
                this._entry.clutter_text.connect('key-focus-out', () =>
                    this._finishEditing()
                )
  • indicator.js:60
                this._minusBtn.connect('clicked', () =>
                    this._adjustDuration(-DurationLimits.STEP)
                )
  • indicator.js:89
                this._plusBtn.connect('clicked', () =>
                    this._adjustDuration(DurationLimits.STEP)
                )
  • indicator.js:54
    this._resetBtn.connect('clicked', () => this._resetToDefault())
  • indicator.js:220
    this._minusBtn.connect('clicked', () => this._adjust(-1))
  • indicator.js:232
    this._plusBtn.connect('clicked', () => this._adjust(1))
  • indicator.js:214
    this._resetBtn.connect('clicked', () => this._resetToDefault())

All Versions

Version Status
2.1 (9) Unreviewed
2.0 (8) Active
2.0 (7) Rejected
1.3 (6) Active
1.2 (5) Active
1.1.1 (4) Rejected
1.1 (3) Rejected
1.0.1 (2) Rejected
1 Rejected