1. Please remove from `metadata.json`: - `git-version` - `original-authors` - `fork-maintainer` 2. Schema id shouldn't be the same as the fork. 3. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 4. Wrong gettxt domain in the schemas xml file. 5. Please remove version from the import: - line 18 `openweathermap.js` - line 21 `preferences/locationsPage.js` 6. You cannot hold instances of objects in global scope (line 429 `openweathermap.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 7. Where the `loadJsonAsync()` defined in 263 `extension.js` is used? 8. Pleas remove line 32 `extension.js`. 9. You cannot import `Gtk` and `Gdk` to the GNOME Shell process (line 20-21 `extension.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 10. Bad practice (line 1595 `extension.js`). Rename `OpenWeatherMenuButton.stop()` function to `destroy()` and do `super.destroy()` at the end of that function. 11. You should call `abort()` on disable (line 506 `openweathermap.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 12. Avoid sending large diff. It is hard to review and it takes time to review. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions