Review of "OpenWeather Modern" version 4

Details Page Preview

Modern fork of OpenWeather for GNOME Shell 45-50 with ESM modules. Display weather information for any location on Earth.

Extension Homepage
https://github.com/mateusfbrandao/openweather-modern

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
5 Unreviewed
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Is this code generated by AI? If so, we have a rule for that: - [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) - [Extensions Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html#submissions-require-maintainership)
Tiuris posted a review
Hi @JustPerfection, This is a fork of OpenWeather (Jens Lody, later maintained by Jason Oickle), ported to ESM for GNOME Shell 45-50. I work as a web developer, and since GJS is new to me, I used AI to help fix some errors and speed up parts of the migration. I maintain this fork, I run it daily, and I can explain the code. enable() creates the panel button. disable() calls stop() and then destroy(). stop() cancels the Soup request, removes the timeouts and disconnects the signals. Weather data is fetched in openweathermap.js. The settings schema id is org.gnome.shell.extensions.openweather-modern, so it does not share dconf with the original extension. Because I work with web JS, I had added a lot of typeof === 'function' guards and optional chaining (?.) out of habit. Those are removed in this upload. The code now calls the Shell 45-50 APIs directly. The two places that really differ by version each have one branch and a comment: the forecast adjustment uses hscroll on Shell 45 and get_hadjustment() from 46 on, and dragging uses Clutter.PanAction through Shell 47 and Clutter.PanGesture from 48 on.
Tiuris auto- rejected
Auto-rejected because of new version 5 was uploaded
Tiuris posted a review
Hi @JustPerfection, This is a fork of OpenWeather (Jens Lody, later maintained by Jason Oickle), ported to ESM for GNOME Shell 45-50. I work as a web developer, and since GJS is new to me, I used AI to help fix some errors and speed up parts of the migration. I maintain this fork, I run it daily, and I can explain the code. enable() creates the panel button. disable() calls stop() and then destroy(). stop() cancels the Soup request, removes the timeouts and disconnects the signals. Weather data is fetched in openweathermap.js. The settings schema id is org.gnome.shell.extensions.openweather-modern, so it does not share dconf with the original extension. Because I work with web JS, I had added a lot of typeof === 'function' guards and optional chaining (?.) out of habit. Those are removed in this upload. The code now calls the Shell 45-50 APIs directly. The two places that really differ by version each have one branch and a comment: the forecast adjustment uses hscroll on Shell 45 and get_hadjustment() from 46 on, and dragging uses Clutter.PanAction through Shell 47 and Clutter.PanGesture from 48 on.