Review of "Tailscale Quick Settings Toggle" version 1

Details Page Preview

Add Tailscale to GNOME quick settings. Fork of joaophi/tailscale-gnome-qs with continued maintenance and improvements. Make sure you set your user as tailscale operator: sudo tailscale set --operator=$USER

Extension Homepage
https://github.com/tailscale-qs/tailscale-gnome-qs

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Unreviewed
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

alexjfinch posted a review
JustPerfection rejected
1. Remove files: - `compat.js` - `.po` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Remove line 327-330 `extension.js`. Not needed. 3. The `timeout.js` is the old way, you don't really need that file anymore. After removing that file, don't forget to manually remove the timeouts on destroy and disable. Also before creating a new one. 4. You should call `abort()` on disable (line 13 `tailscale.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 5. Also, if this a fork, you need to mention in the description that this extension is a fork of the other extension: [EGO Review Guidelines: Fork](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions