Review of "Tailscale Quick Settings Toggle" version 2

Details Page Preview

Add Tailscale to GNOME quick settings. Fork of joaophi/tailscale-gnome-qs with continued maintenance and improvements. Make sure you set your user as tailscale operator: sudo tailscale set --operator=$USER

Extension Homepage
https://github.com/tailscale-qs/tailscale-gnome-qs

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Unreviewed
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on destroy (line 316 `tailscale.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. Please avoid sending large diff.
alexjfinch posted a review
I've uploaded version 3 with only the timeout cleanup fix requested in point #1. The diff is now minimal (only changes to timeout tracking in tailscale.js). Regarding the large diff in version 2: It included all the changes requested in the first review (removing compat.js, timeout.js, .po files, fixing profiles, etc.). Should these have been submitted as separate versions instead?