Review of "P7 Commands" version 23

Details Page Preview

Sensible commands like window auto resize, mouse move resize, etc

Extension Homepage
https://github.com/prasannavl/p7-cmds-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
Did you use AI here? There are so many lines of function and typeof checks. Also, please don't send large diff since it is hard to review.
Prasanna Loganathar posted a review
Hi, AI is used, but more as a helper tool for refactoring than letting it drive. > There are so many lines of function and typeof checks. All of it AFAIR, should be all in the compat.js file which is meant to check these for picking the right APIs across different versions. - https://github.com/prasannavl/p7-cmds-shell-extension/commit/9af59a0517d0d26cb0c2f4add1063a9b46809114 - https://github.com/prasannavl/p7-cmds-shell-extension/commit/f0951ac9f72bc119fe960b1f75e8343d1d935e47 - https://github.com/prasannavl/p7-cmds-shell-extension/commit/38d4f31615278caf918600387a720bddf2092d50 - https://github.com/prasannavl/p7-cmds-shell-extension/commit/67179862da2d5027fcc3ae6f289763aec45982f1 I ended up adding them gradually, after trying to read through mutter docs and often resulting in errors to create a reliable cursor tracker that's compatible with a wide range of versions, so had to do these defensive checks. Please feel free to let know if you think I can reduce the code here reliably and without relying on these checks. Happy to clean it up more if you could add some guidance on what I can cleanup here. They are cheap checks and none of these were in the hotpath either and worked well, so keeping the defensive checks resulted in better results than unnecessary noise in the logs.
Prasanna Loganathar posted a review
> Also, please don't send large diff since it is hard to review. Of course, sorry it ended up large with some refactors and cleanups. But I think the code org is settled now, so hopefully should just be simpler from this point on.
JustPerfection active
Something like `=== "function"` is what AI is doing. I'm going to approve it for now but for the next update, please do GNOME Shell version check instead. That way is more maintainable.