Review of "Updated VLAN Switcher" version 2

Details Page Preview

Activate and deactivate VLAN connections from the system panel.

Extension Homepage
https://github.com/JrVolt/GNOME_VLAN_Toggle

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove `gettext-domain` (line 3 `schemas/org.gnome.shell.extensions.updated-vlan-switcher.gschema.xml`). 2. Remove files and folders: - `.git` - `.po` - `.pot` - `IMG` 3. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 4. Remove 42-44. Not compatible with those versions. 5. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. ```json "settings-schema": "org.gnome.shell.extensions.updated-vlan-switcher", ``` 6. You cannot use old `imports` in 45+ extensions (line 17 `extension.js`). 7. Don't use try-catch block in global scope (line 16 `extension.js`). 8. Remove line 327-329 `extension.js`. 9. Also null out in disable: ```js this._settings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 10. Please disconnect signals on disable (line 43, 46, 118-119, 213, 216 `extension.js`): [EGO Review Guidelines: Disconnect all signals](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions