Review of "Updated VLAN Switcher" version 4

Details Page Preview

Activate and deactivate VLAN connections from the system panel.

Extension Homepage
https://github.com/JrVolt/GNOME_VLAN_Toggle

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JrVolt posted a review
Tested on GNOME 49 with Ubuntu 25.10 and 26.04, seems ok. I'll update the compatibility with 49 if everything else is fine. How safe is adding support for 47 and 48 too ? if I understand correctly they should works too. Thanks.
JrVolt posted a review
JustPerfection rejected
1. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. 2. You have `this.openPreferences()` in the entry point. You cannot use spawn command for that (line 134, 257 `extension.js`). 3. Remove `|| class {}` from line 13-14 `extension.js`. 4. Remove `gettext-domain="gnome-shell-extensions"` from line 3 `schemas/org.gnome.shell.extensions.updated-vlan-switcher.gschema.xml`.